Attention is currently required from: Nico Huber, Anastasia Klimchuk, Sergii Dmytruk.
Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59075 )
Change subject: [RFC][WPTST] tests: test write protection
......................................................................
Patch Set 13:
(1 comment)
File tests/chip_wp.c:
https://review.coreboot.org/c/flashrom/+/59075/comment/9c765b72_3eb8086a
PS13, Line 260: 1
I am a bit confused, this used to be 0 (successful case) and now set_mode fails? with the same input […]
This is probably because I removed support for setting power cycle / permanent protection in a recent patchset: https://review.coreboot.org/c/flashrom/+/58483/23.
The reason I removed it being that those modes aren't widely supported and have a lot of vendor-specific requirements to activate when they are supported.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/59075
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I49af7f6d173eb4c56c22d80b01a473b8c499c0f8
Gerrit-Change-Number: 59075
Gerrit-PatchSet: 13
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-CC: Nikolai Artemiev
nartemiev@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Mon, 06 Dec 2021 09:58:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment