Change in flashrom[master]: usbdev: Extract libusb1 device discovery into a seperate file - flashrom-gerrit

18 Aug 2018


      Nico Huber has posted comments on this change. ( https://review.coreboot.org/27443 )
Change subject: usbdev: Extract libusb1 device discovery into a seperate file
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/27443/2/usbdev.c
File usbdev.c:
https://review.coreboot.org/#/c/27443/2/usbdev.c@18
PS2, Line 18: #include "platform.h"
doesn't seem useful here?
https://review.coreboot.org/#/c/27443/2/usbdev.c@22
PS2, Line 22: #include "programmer.h"
Do we need this? or just fash.h?
-- 
To view, visit https://review.coreboot.org/27443
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idfcc79371241c2c1dea97faf5e532aa971546a79
Gerrit-Change-Number: 27443
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Thompson daniel.thompson@linaro.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Sat, 18 Aug 2018 14:27:53 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No