[L] Change in flashrom[master]: tests: Unit tests for erase function selection algo - flashrom-gerrit

9 Jun 2023


      Attention is currently required from: Aarya, Simon Buhrow, Thomas Heijligen.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67535?usp=email )
Change subject: tests: Unit tests for erase function selection algo
......................................................................
Patch Set 8:
(1 comment)
Patchset:
PS8: 
I made it work!
It turns out that the hacks I was using in Oct last year are not applicable anymore, and I needed to figure out different hacks :)
I plan to add assertion for expected order of erase blocks invocations, and also address all the comments. And then it will be ready!
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/67535?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I8f3fdefb76e71f6f8dc295d9dead5f38642aace7
Gerrit-Change-Number: 67535
Gerrit-PatchSet: 8
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Aarya aarya.chaumal@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Simon Buhrow
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Alexander Goncharov chat@joursoir.net
Gerrit-CC: Nikolai Artemiev nartemiev@google.com
Gerrit-Attention: Simon Buhrow
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Attention: Aarya aarya.chaumal@gmail.com
Gerrit-Comment-Date: Fri, 09 Jun 2023 13:34:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment