Attention is currently required from: Richard Hughes, Edward O'Callaghan, Patrick Rudolph.
Richard Hughes has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49643 )
Change subject: libflashrom: Return progress state to the library user
......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS3:
Okay, rebased without the floating point.
File cli_output.c:
https://review.coreboot.org/c/flashrom/+/49643/comment/a83988be_ebffdb51
PS2, Line 84: double
that could be slow on soft float CPUs. […]
We could... but I think the msleeps between the SPI transactions are going to be orders of magnitude slower. We could of course do something like:
pc = ((unsigned long long) current * 10000) / ((unsigned long long) total * 100);
If this works for you I'll respin the patch with that.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/49643
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7197572bb7f19e3bdb2bde855d70a0f50fd3854c
Gerrit-Change-Number: 49643
Gerrit-PatchSet: 3
Gerrit-Owner: Richard Hughes
richard@hughsie.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Richard Hughes
hughsient@gmail.com
Gerrit-Attention: Richard Hughes
richard@hughsie.com
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sat, 30 Jan 2021 16:58:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment