Change in flashrom[master]: endian: Decide __FLASHROM_XXX_ENDIAN__ in the buildsystem - flashrom-gerrit

12 Oct 2021


      Attention is currently required from: Nico Huber, Thomas Heijligen, Angel Pons.
 Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58273 )
Change subject: endian: Decide __FLASHROM_XXX_ENDIAN__ in the buildsystem
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/58273/comment/43255df7_1685a6b5 
PS2, Line 7: endian: Decide __FLASHROM_XXX_ENDIAN__ in the buildsystem
I would rewrite that. How about this?
Let the buildsystem detect the endianness
Both, the Meson and the Makefile buildsytem, know about the endianness
  of the system. Thus, use their built-in functions to decide that and
  get rid of unnecessary C code.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/58273
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I37093528ae55e712cc30a0267a8ceac332750e7d
Gerrit-Change-Number: 58273
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Heijligen src@posteo.de
Gerrit-Reviewer:  Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 12 Oct 2021 19:12:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment