Attention is currently required from: Vasily Galkin, Thomas Heijligen, roman.stingler@gmail.com. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58179 )
Change subject: Add support for IS25WQ040 ......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/58179/comment/348d3a10_d5d632f4 PS1, Line 7: Add support for IS25WQ040 Add `flashchips.c: ` before that
https://review.coreboot.org/c/flashrom/+/58179/comment/78782ed9_00e4dfe9 PS1, Line 10: Signed-off-by: Roman Stingler roman.stingler@gmail.com Put the Sign-offs after the line with the Change-Id. This one should come first.
https://review.coreboot.org/c/flashrom/+/58179/comment/c533e841_6842ed9f PS1, Line 11: Add a link to the datasheet.
https://review.coreboot.org/c/flashrom/+/58179/comment/769020a9_1f3f5322 PS1, Line 12: Did you test it? How? Which programmer did you use?