Attention is currently required from: Anastasia Klimchuk, DZ, Nikolai Artemiev, Stefan Reinauer.
Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81792?usp=email )
Change subject: flashchips: Split and add write-protect support for MX25L12833F
......................................................................
Patch Set 6:
(3 comments)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/81792/comment/cffc1cb7_962b73b8 :
PS5, Line 9038: /* TODO: security register and SBLK/SBULK; */
I am not sure what is SBLK/SBULK but I think this TODO can be removed.
Done
https://review.coreboot.org/c/flashrom/+/81792/comment/284b3f19_35e4721d :
PS5, Line 9086: /* TODO: security register and SBLK/SBULK; MX25L12835F: configuration register */
Same: this TODO can be removed
Done
https://review.coreboot.org/c/flashrom/+/81792/comment/daef3e20_28dc1cd3 :
PS5, Line 9134: /* TODO: security register and SBLK/SBULK */
Same: this TODO can be removed
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/81792?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I379c833eea3ed3487504126f45c6df672a772ddc
Gerrit-Change-Number: 81792
Gerrit-PatchSet: 6
Gerrit-Owner: Hsuan-ting Chen
roccochen@google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: DZ
danielzhang@mxic.com.cn
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hsuan Ting Chen
roccochen@chromium.org
Gerrit-Attention: DZ
danielzhang@mxic.com.cn
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Thu, 18 Apr 2024 13:11:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment