Change in flashrom[master]: linux_mtd: Disable buffering on the mtd device - flashrom-gerrit

1 Feb 2021


      Attention is currently required from: Hung-Te Lin, David Hendricks, Edward O'Callaghan.
Douglas Anderson has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/50155 )
Change subject: linux_mtd: Disable buffering on the mtd device
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
...
I'm surprised why we didn't see issues until now.
In the meantime, will it make more sense if we change fopen to open for MTD device files?
I can do a follow-up change since this is +2 and feels safer (touches less code).
I don't seem to be setup for access to actually submit this change.  Can anyone help me with that?
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/50155
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I989afd83a33013b2756a0090d6b08245613215c6
Gerrit-Change-Number: 50155
Gerrit-PatchSet: 2
Gerrit-Owner: Douglas Anderson dianders@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Vadim Bendebury vbendeb@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: David Hendricks david.hendricks@gmail.com
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Comment-Date: Mon, 01 Feb 2021 14:45:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin hungte@chromium.org
Gerrit-MessageType: comment