Attention is currently required from: Wonkyu Kim, Anastasia Klimchuk.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62783 )
Change subject: ichspi: Add support for Meteor Lake
......................................................................
Patch Set 4:
(2 comments)
File util/ich_descriptors_tool/ich_descriptors_tool.c:
https://review.coreboot.org/c/flashrom/+/62783/comment/802f9b39_1ecd7180
PS3, Line 130: "\t- "gemini" for Intel's Gemini Lake SoC.\n"
Seems to make sense to group named SoC's together over the other topology of x00 series? Lets see wh […]
Ack
https://review.coreboot.org/c/flashrom/+/62783/comment/71a09015_75297978
PS3, Line 241: else if (strcmp(csn, "meteor") == 0)
: cs = CHIPSET_METEOR_LAKE;
should this be moved down a bit to be ordered in the same way the others are to be consistent? […]
Ack
--
To view, visit
https://review.coreboot.org/c/flashrom/+/62783
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0a2ffe2ba8d96c90d89b77e0d8583d179ff02a75
Gerrit-Change-Number: 62783
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Wonkyu Kim
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Wonkyu Kim
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Mon, 14 Mar 2022 11:13:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Gerrit-MessageType: comment