Attention is currently required from: Peter Marheine. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51967 )
Change subject: lspcon_i2c_spi: support a devpath option ......................................................................
Patch Set 1: Code-Review+1
(3 comments)
File i2c_helper_linux.c:
https://review.coreboot.org/c/flashrom/+/51967/comment/45504807_c0973a47 PS1, Line 46: goto err; `goto` isn't necessary here, just return `fd`.
https://review.coreboot.org/c/flashrom/+/51967/comment/41a9c15d_338637ac PS1, Line 54: goto err; Same here, just return `err`.
https://review.coreboot.org/c/flashrom/+/51967/comment/a23a2a96_c0d8332c PS1, Line 58: return ret ? ret : fd; And return `fd` here.