Attention is currently required from: Dmitry Zhadinets.
Anastasia Klimchuk has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/86946?usp=email )
Change subject: libflashrom: Added API for capabilitible chips ......................................................................
Patch Set 1:
(5 comments)
Patchset:
PS1: I started adding comments, but now I am thinking about the patch overall: is this the idea which was #3 in your thread on the mailing list? The idea that libflashrom probing should work in the same way as cli?
As you know, I also want to have the same probing logic for libflashrom and cli. But I was thinking to have it as an actual v2 probing API. If we add a v2 probing which behaves like cli, will it solve your use case, so that you won't need this patch anymore?
File include/libflashrom.h:
https://review.coreboot.org/c/flashrom/+/86946/comment/989be7b2_ad970ee6?usp... : PS1, Line 230: fo for (typo)
https://review.coreboot.org/c/flashrom/+/86946/comment/67762844_afd8c1de?usp... : PS1, Line 231: * @param[in] flashprog The flash programmer used to access the chip. We usually add a line between brief and the rest, also a line between param and return
File libflashrom.map:
https://review.coreboot.org/c/flashrom/+/86946/comment/d03504db_416557a7?usp... : PS1, Line 34: flashrom_supported_programmers This needs to be in the previous commit CB:86921
File tests/tests.c:
https://review.coreboot.org/c/flashrom/+/86946/comment/ea60ba36_3ef56d27?usp... : PS1, Line 456: const struct CMUnitTest libflashrom_tests[] = { : cmocka_unit_test(enumerators_test_success), : }; : ret |= cmocka_run_group_tests_name("libflashrom.c tests", libflashrom_tests, NULL, NULL); What is the reason you are moving these lines? If this is accidental, please return then back :)