Attention is currently required from: Simon Buhrow, Edward O'Callaghan, Samir Ibradžić. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40477 )
Change subject: ft2232_spi.c: Implement spi_send_multicommand() ......................................................................
Patch Set 32:
(1 comment)
Patchset:
PS32:
- I´m running flashrom on a virutal machine (don´t think this makes any difference)
This explains it (unless you have passed the whole USB controller into the VM). Emulated USB controllers cause a high latency for individual packets. The dediprog driver is also optimized to avoid waiting on packets (at least for reading) because I use it much with virtualbox.
NB: yepp, I noticed that with the erase block size, as well and have it on my todo list. I was thinking about something like comandline parameter to select block size or an extra parameter at flashchips.c to mark the preferred block size. May be we should open a new patch for that to discuss ideas... (it was just because of lack of support for this patch for month why I did not step further)
Giving a hint on the command line might work. The "preferred" block size depends on the writing pattern, i.e. how big are the changed chunks compared to current flash contents. So that's nothing to predict.
-
Nico Huber (Code Review)