Attention is currently required from: Nico Huber, Maciej Pijanowski, Angel Pons, Anastasia Klimchuk, Nikolai Artemiev.
Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66212 )
Change subject: writeprotect_ranges.c: add more range functions
......................................................................
Patch Set 8:
(1 comment)
Patchset:
PS3:
Thanks for committing those.
I went through the chain, there are unresolved comments on one of the patches, and also the chain probably needs rebasing?
I see merge conflict, will rebase when doing changes. There is a discussion about preferred handling of vendor-specific register naming, not sure how to move it forward.
Also do you plan to make any changes to the next 4 patches "enable WP for..." after CB:68179 and CB:68180 have been merged?
I've already did that in the last patchset.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/66212
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ied7b27be2ee2426af8f473432e2b01a290de2365
Gerrit-Change-Number: 66212
Gerrit-PatchSet: 8
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk
aklm@chromium.org
Gerrit-CC: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Thu, 03 Nov 2022 13:15:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Comment-In-Reply-To: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-MessageType: comment