Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk, Peter Marheine. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63724 )
Change subject: [WIP] meson: rework the programmer selection ......................................................................
Patch Set 3:
(4 comments)
File meson.build:
https://review.coreboot.org/c/flashrom/+/63724/comment/d86b9542_d0cda658 PS2, Line 98: # 'deps' : list[dep], # fallback: []
Could each dep list additional files that it requires? It looks like every programmer that depends o […]
I'll have a deeper look at it. But I don't think so. I would prefer to have all code needed to build a programmer in the programmers `srcs` list. The code in `pcidev.c` is just a bunch of functions that is shared between programmers.
https://review.coreboot.org/c/flashrom/+/63724/comment/48a9fd69_1c9537e8 PS2, Line 418: p_x.get('deps',[])
deps is already defaulted to [] above, so this doesn't need to specify a fallback.
Done
https://review.coreboot.org/c/flashrom/+/63724/comment/866b8e0e_a2764976 PS2, Line 427: elif selected and available
Seems clearer to nest these, since it isn't immediately obvious that this is the same condition as a […]
I found non nested if statements easier. We would need more than 2 levels of nesting to get this right. selected (y) / \ (n) available selected_all+available (y) / \ (n) (y) / \ (n) deps_found error() deps_found selected_auto+available+deps_found (y) / \ (no) (y) / \ (n) (y) | active=true error() active=true error() active=true
https://review.coreboot.org/c/flashrom/+/63724/comment/9e5ad60e_648c3d48 PS2, Line 464: if host_machine.system() in systems_serial_support
Could we avoid building this if no programmer needs serial? Might need a bit of rework to express it […]
I haven't looked deeply into the serial code how to build it the bust way. But I think there is code shared between the programmer (`serial.c`) and code to support the operating system (`custom_baud/_linux/.c`). For now I've put it to the respective programmer.
-
Thomas Heijligen (Code Review)