Attention is currently required from: Peter Marheine, Simon Arlott.
Anastasia Klimchuk has posted comments on this change by Simon Arlott. ( https://review.coreboot.org/c/flashrom/+/86411?usp=email )
Change subject: spidriver: Add support for the Excamera Labs SPIDriver programmer ......................................................................
Patch Set 7:
(4 comments)
Patchset:
PS5:
I've added a test and found a bug writing the SPI mode. […]
Simon, thank you so much for your work! Your test is so well written, and so detailed, it is very impressive! I will close this comment thread. I added few small comments to the latest version of the patch.
File tests/spidriver.c:
https://review.coreboot.org/c/flashrom/+/86411/comment/5b02879a_4c9869d1?usp... : PS7, Line 4: * Copyright 2021 Google LLC I don't think this line is needed here? I would just leave your name (just line #5). You wrote a brand new test.
https://review.coreboot.org/c/flashrom/+/86411/comment/cd47edc5_72905efe?usp... : PS7, Line 83: snprintf((char *)ts->input, sizeof(ts->input), "[spidriver2 AAAAAAAA 000000002 5.190 000 21.9 1 1 1 ffff 0 ]"); This line length goes above our limit (112 chars), but I think if you put arguments on new lines it should be fine.
I mean like this
``` snprintf((char *)ts->input, sizeof(ts->input), "[spidriver2 AAAAAAAA 000000002 5.190 000 21.9 1 1 1 ffff 0 ]"); ```
File tests/tests.c:
https://review.coreboot.org/c/flashrom/+/86411/comment/9c295399_a9288833?usp... : PS7, Line 27: : struct termios; : I don't think you need this line here, because `wraps.h` is already included, and wraps.h has this line (also things like that are meant to be in wraps.h anyway)