Attention is currently required from: Thomas Heijligen, Stefan Reinauer, Edward O'Callaghan, Alexander Goncharov.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74216 )
Change subject: doc: Convert README to sphinx ......................................................................
Patch Set 6:
(19 comments)
Patchset:
PS5:
The "Build Instructions" section looks like a wall of text. It's difficult to read and navigate. […]
Thank you so much for your thorough review, and for attention to details! This is so important! I fixed all the comments.
Would you like to add yourself as maintainer for doc directory? If yes, please send a patch! That would be three people for doc directory, and I think it's great. It doesn't mean that all three need to approve, one is enough. But it means higher chance one of us have time to review the patch, if we get contributors for docs.
File README.rst:
https://review.coreboot.org/c/flashrom/+/74216/comment/44500077_ada69c9f PS5, Line 26: flashrom supports building with make and meson.
Done
https://review.coreboot.org/c/flashrom/+/74216/comment/56f9990e_d7f979ca PS5, Line 38: To build flashrom you need to install the following software:
Done
https://review.coreboot.org/c/flashrom/+/74216/comment/293b7695_03fb984b PS5, Line 48: Linux et al:
Done
https://review.coreboot.org/c/flashrom/+/74216/comment/ba83eae3_aa1675bb PS5, Line 54: On FreeBSD, you need the following ports:
Done
https://review.coreboot.org/c/flashrom/+/74216/comment/efb2f6b7_4c160625 PS5, Line 59: On OpenBSD, you need the following ports:
Done
https://review.coreboot.org/c/flashrom/+/74216/comment/3f10b623_3ec4b5c2 PS5, Line 64: To compile on Linux, use::
Done
https://review.coreboot.org/c/flashrom/+/74216/comment/d875eee8_a5942dbc PS5, Line 68: To compile on FreeBSD, OpenBSD or DragonFly BSD, use::
Done
https://review.coreboot.org/c/flashrom/+/74216/comment/5372191e_9c17717b PS5, Line 72: To compile on Nexenta, use::
Done
https://review.coreboot.org/c/flashrom/+/74216/comment/c4e19970_ef2fb1d0 PS5, Line 76: To compile on Solaris, use::
Done
https://review.coreboot.org/c/flashrom/+/74216/comment/b9511e72_e1e9b259 PS5, Line 80: To compile on NetBSD (with pciutils, libftdi, libusb installed in /usr/pkg/), use::
Done
https://review.coreboot.org/c/flashrom/+/74216/comment/09574ff6_ff028c9a PS5, Line 84: To compile and run on Darwin/Mac OS X:
Done
https://review.coreboot.org/c/flashrom/+/74216/comment/6b57f962_6dfbd388 PS5, Line 89: To cross-compile on Linux for DOS:
Done
https://review.coreboot.org/c/flashrom/+/74216/comment/4e33c473_a0385945 PS5, Line 138: To cross-compile on Linux for Windows:
Done
https://review.coreboot.org/c/flashrom/+/74216/comment/6bbf6cf4_77b1ca84 PS5, Line 152: Processor architecture dependent features:
Done
https://review.coreboot.org/c/flashrom/+/74216/comment/3a76eaf6_8af4bd6e PS5, Line 158: Compiler quirks:
Done
https://review.coreboot.org/c/flashrom/+/74216/comment/57e2e3bd_9fd6f030 PS5, Line 164: Bindings:
Done
https://review.coreboot.org/c/flashrom/+/74216/comment/5126bc3c_9ef6498e PS5, Line 197: 'make export'
Done
https://review.coreboot.org/c/flashrom/+/74216/comment/e5143ef6_d54fa34a PS5, Line 203: 'make tarball'
Done
-
Anastasia Klimchuk (Code Review)