[XS] Change in flashrom[main]: erasure_layout: Fix init_eraseblock segmentation fault

[DigitalDJ (Code Review)]

Attention is currently required from: Aarya, DigitalDJ.

Hello Aarya, Anastasia Klimchuk, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/flashrom/+/84234?usp=email

to look at the new patch set (#5).

Change subject: erasure_layout: Fix init_eraseblock segmentation fault
......................................................................

erasure_layout: Fix init_eraseblock segmentation fault

Fix a segmentation fault that is caused by accessing an invalid
"subedata" pointer on the last iteration of the init_eraseblock loop.
Instead, short circuit the loop condition to check the sub block index
first, and do not access the invalid pointer if it is the last sub
block.

Issue was encountered in:
- OS: OpenBSD 7.5 amd64
- Compiler: clang 16.0.6
- Chip: Macronix MX25U6435E/F

BUG=https://ticket.coreboot.org/issues/555

Change-Id: I61bf0d93aa9f0b2b420b146be16fcd5124f0dc5d
Signed-off-by: Grant Pannell 
---
M erasure_layout.c
1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/34/84234/5