Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/29093 )
Change subject: ati: add rv730/rv740 support
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/29093/2/ati_spi.c
File ati_spi.c:
https://review.coreboot.org/#/c/29093/2/ati_spi.c@34
PS2, Line 34: #define ATI_SPI_TYPE_R600 1
: #define ATI_SPI_TYPE_RV730 2
: int type;
use an enum?
--
To view, visit
https://review.coreboot.org/29093
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b6abc817c7ba0f12adc94c07bf81de118adffe5
Gerrit-Change-Number: 29093
Gerrit-PatchSet: 2
Gerrit-Owner: Luc Verhaegen
libv@skynet.be
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Sat, 20 Oct 2018 12:42:40 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No