Attention is currently required from: Felix Singer, Thomas Heijligen.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64031 )
Change subject: meson: use objects form libflashrom
......................................................................
Patch Set 6: Code-Review-1
(1 comment)
File meson.build:
https://review.coreboot.org/c/flashrom/+/64031/comment/d9739a26_594a832c
PS6, Line 512: compile_args : [
: '-includestdlib.h',
: '-includeunittest_env.h',
: '-includehwaccess_x86_io_unittest.h'
: ],
The -includestdlib.h is handled in the previous patch in the chain. […]
I added a long comment into previous patch CB:64385 which applies to both patches. Thanks!
--
To view, visit
https://review.coreboot.org/c/flashrom/+/64031
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If10ed70e3bf629a6eb7e2c5bef3318d1e259dadd
Gerrit-Change-Number: 64031
Gerrit-PatchSet: 6
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Comment-Date: Mon, 23 May 2022 21:39:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment