Shawn Anastasio has posted comments on this change. ( https://review.coreboot.org/23057 )
Change subject: buspirate_spi: Add support for variable serial speeds ......................................................................
Patch Set 6:
(3 comments)
https://review.coreboot.org/#/c/23057/6/buspirate_spi.c File buspirate_spi.c:
https://review.coreboot.org/#/c/23057/6/buspirate_spi.c@443 PS6, Line 443: 5.5
Where is this written? This page talks about 5.2: […]
Firmware versions 5.2-5.4 do support setting custom baud rates, but without the improved SPI mode in 5.5 you run into a lot of buffer overruns which slow down the read/write and defeat the purpose of increasing the baud rate.
https://review.coreboot.org/#/c/23057/6/buspirate_spi.c@451 PS6, Line 451: " Continue at your own risk.\n");
I did some research, v2 can work with the same firmware and uses the […]
This repository which seems to contain the latest firmware states that only boards v3 and v4 are supported: https://github.com/BusPirate/Bus_Pirate.
I could still remove the warning if you'd like, but I think leaving it there until someone with a v2 comes along and tests it isn't a bad idea.
https://review.coreboot.org/#/c/23057/6/buspirate_spi.c@473 PS6, Line 473: sleep(1);
Is this specified somewhere? It seems incredibly long.
It's really just a safe value. I could try to optimize it to the lowest value that works on my v3 but I'm not sure if it's worth it, especially if it causes breakage on other models.
-
Shawn Anastasio (Code Review)