Attention is currently required from: Stefan Reinauer, Anastasia Klimchuk, Peter Marheine, Alexander Goncharov.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73359 )
Change subject: doc: Add build instructions
......................................................................
Patch Set 5:
(2 comments)
File doc/conf.py:
https://review.coreboot.org/c/flashrom/+/73359/comment/39acd7fd_c97f1105
PS4, Line 27: todo_include_todos = False
The name of this option isn't clear enough, so how about adding a comment before it (taken from sphi […]
Done
File doc/index.rst:
https://review.coreboot.org/c/flashrom/+/73359/comment/49374f3d_38c210e6
PS4, Line 7: :glob:
As far as I understand, it's used for globbing. But there's no wildcard pattern.. […]
Ups, was a leftover
--
To view, visit
https://review.coreboot.org/c/flashrom/+/73359
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I96771e98b313a6d26dd2be940ff37998d4124324
Gerrit-Change-Number: 73359
Gerrit-PatchSet: 5
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Alexander Goncharov
chat@joursoir.net
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Edward O'Callaghan
quasisec@chromium.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Attention: Alexander Goncharov
chat@joursoir.net
Gerrit-Comment-Date: Wed, 08 Mar 2023 20:54:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alexander Goncharov
chat@joursoir.net
Gerrit-MessageType: comment
Thomas Heijligen (Code Review)