Attention is currently required from: Felix Singer, Thomas Heijligen, Edward O'Callaghan, Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67474 )
Change subject: flashrom.c: Make emergency_help_message() static local ......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/67474/comment/23f17d37_d61e04e5 PS2, Line 10: agnostic
Actually... […]
That was my thought as well. We could move all the *_help_message() functions into the CLI, I guess.
Another way to eliminate the need for any `is_internal` would be to extend the programmer abstraction. For instance, in this case, `programmer_entry` could get pointers to functions that print the correct message. With a NULL => default for most programmers?
Generally, the idea to have something like an `is_internal` means the programmer struct is insufficient. But it seems moving the prints to the CLI would avoid all the trouble (for this case). WDYT?