[S] Change in flashrom[master]: tests: Add wrap for __fprintf_chk - flashrom-gerrit

18 Oct 2022


      Attention is currently required from: Felix Singer, Thomas Heijligen, Anastasia Klimchuk.
Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68432 )
Change subject: tests: Add wrap for __fprintf_chk
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2: 
This doesn't seem clang-specific; it looks like glibc does this if `_FORTIFY_SOURCE` is enabled (something around `libio/bits/stdio2.h` in glibc). There are many other similar functions which we would also conceivably need to be wrapped, so I think the alternate option of setting `_FORTIFY_SOURCE` to 0 when building tests is better.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/68432
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I70cb1cd90d1f377ff4606acad3c1b514120ae4f7
Gerrit-Change-Number: 68432
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Peter Marheine pmarheine@chromium.org
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Tue, 18 Oct 2022 22:45:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment