Change in flashrom[master]: realtek_mst_i2c_spi.c: Move gpio 88 toggle outside write function - flashrom-gerrit

11 Feb 2021


      Attention is currently required from: Sam McNally, Shiyu Sun, Edward O'Callaghan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49785 )
Change subject: realtek_mst_i2c_spi.c: Move gpio 88 toggle outside write function
......................................................................
Patch Set 4: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/49785/comment/7f0ac929_be17754a 
PS2, Line 9: Gpio 88 toggle is used as write protection disable/enable now
           : and we need that to happen at the initialization of programmer.
...
Sadly it is unlikely Shiyu will respond to comments any more. […]
Alright
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/49785
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I237bf9f8aa0fcbb904e7f0c09c74fd179e8c70c1
Gerrit-Change-Number: 49785
Gerrit-PatchSet: 4
Gerrit-Owner: Shiyu Sun sshiyu@google.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Sam McNally sammc@google.com
Gerrit-Attention: Sam McNally sammc@google.com
Gerrit-Attention: Shiyu Sun sshiyu@google.com
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Comment-Date: Thu, 11 Feb 2021 09:46:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment