Change in flashrom[staging]: Move register decodes into enable_flash_ich_handle_gcs()

[Youness Alaoui (Code Review)]

Youness Alaoui has posted comments on this change. ( https://review.coreboot.org/18882 )

Change subject: Move register decodes into enable_flash_ich_handle_gcs()
......................................................................

Patch Set 2:

The only comment I'd have is whether checking only bit 0 of top_swap is correct.
You changed top_swap from being `mmio_readb(rcrb + 0x3414)` into  `mmio_readb(rcrb + 0x3414) & 1`. While that makes it valid bool, it's not necessarily a valid cast of uint8_t into a bool.

I don't have the spec (wouldn't know where/what to look for) to check if the bit 0 of rcrb+0x3414 is the one that needs to be used for top_swap, but a better cast would have been to do :
> top_swap = mmio_readb(rcrb + 0x3414) != 0;

The rest looks good, but please verify the above before merging.