Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69131 )
Change subject: tree/: Convert flashchips db to use indirection for erase_block
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS2:
O-oh? Y-you did it, Edward... Thank you so much for giving this idea a try! 😊
Tested by diffing the flashrom executable produced by `make CONFIG_EVERYTHING=yes CONFIG_JLINK_SPI=no VERSION=none -j` before/after applying this patch: resulting binaries are identical.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/69131
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I122295ec9add0fe0efd27273c9725e5d64f6dbe2
Gerrit-Change-Number: 69131
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Wed, 02 Nov 2022 11:20:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment