Change in flashrom[master]: fmap.c: Avoid undefined behaviour with fmap_lsearch([len:=0]) - flashrom-gerrit

2 Feb 2022


      Attention is currently required from: Edward O'Callaghan, Julius Werner.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61545 )
Change subject: fmap.c: Avoid undefined behaviour with fmap_lsearch([len:=0])
......................................................................
Patch Set 1:
(1 comment)
File fmap.c:
https://review.coreboot.org/c/flashrom/+/61545/comment/fabf7585_11ef333a 
PS1, Line 99: 	if (len == 0)
How does a length of zero cause problems? What if len is non-zero but smaller than `sizeof(struct fmap)`?
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/61545
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ifb408c55c3b69ddff453dcc704b7389298050473
Gerrit-Change-Number: 61545
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Comment-Date: Wed, 02 Feb 2022 11:13:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment