Attention is currently required from: Edward O'Callaghan, Martin L Roth, Thomas Heijligen.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74953?usp=email )
Change subject: tree: Update 'sb600' references to 'amd'
......................................................................
Patch Set 2:
(1 comment)
File amd_spi.c:
https://review.coreboot.org/c/flashrom/+/74953/comment/7b5eb5a8_ee92af7f :
PS1, Line 156: amd_spibar
Minor: Since these function parameters are stack local to the working function, how about just dropp […]
I think it's a good idea, would you agree if I do it later in another patch? It's much easier to review this patch when it changes all sb600 into amd.
But I agree with you idea.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/74953?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I1200ef25b6765f809c754ae0adcdcfe680c202fd
Gerrit-Change-Number: 74953
Gerrit-PatchSet: 2
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Comment-Date: Fri, 08 Dec 2023 05:56:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Gerrit-MessageType: comment