Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/82231?usp=email )
Change subject: flashrom-tester: Include flashrom/src/cmd.rs tests in Cargo workspace ......................................................................
flashrom-tester: Include flashrom/src/cmd.rs tests in Cargo workspace
Ensure ChromeOS ebuild (ecargo_test) runs all unit tests, including those under flashrom/src/cmd.rs which were previously being skipped due to not being in the default Cargo workspace.
By adding flashrom/ to the [workspace] section of Cargo.toml, these tests will now be consistently included when building and testing flashrom-tester on ChromeOS.
References: * ebuild of flashrom-tester: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/r... * ecarg_test: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/r...
BUG=b:338962302 TEST=(ChromeOS) FEATURES=`test emerge-corsola flashrom-tester` Could see tests like `cmd::tests::decode_io_opt ... ok` TEST=(UPSTREAM) 1. Build flashrom by `meson` 2. Build bindings/rust/libflashrom by `cargo build` 3. Build util/flashrom_tester by `cargo build` `cargo test --workspace` Could see tests like `cmd::tests::decode_io_opt ... ok`
Change-Id: Ic23bc35592e6d7d8dd24c71630ea9a2eb2d58573 Signed-off-by: Hsuan Ting Chen roccochen@chromium.org Reviewed-on: https://review.coreboot.org/c/flashrom/+/82231 Reviewed-by: Anastasia Klimchuk aklm@chromium.org Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M util/flashrom_tester/Cargo.toml 1 file changed, 3 insertions(+), 0 deletions(-)
Approvals: Angel Pons: Looks good to me, but someone else must approve Anastasia Klimchuk: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/util/flashrom_tester/Cargo.toml b/util/flashrom_tester/Cargo.toml index a76a5b4..50c73dd 100644 --- a/util/flashrom_tester/Cargo.toml +++ b/util/flashrom_tester/Cargo.toml @@ -15,6 +15,9 @@ name = "flashrom_tester" required-features = ["cli"]
+[workspace] +members = [".", "flashrom"] + [dependencies] atty = "0.2" built = { version = "0.5", features = ["chrono"] }