Change in flashrom[master]: Fixed mingw detection on Windows 7 (NT-6.1) and hopefully in another ... - flashrom-gerrit

7 May 2018


      David Hendricks has posted comments on this change. ( https://review.coreboot.org/23865 )
Change subject: Fixed mingw detection on Windows 7 (NT-6.1) and hopefully in another non XP Windows build environments too.
......................................................................
Patch Set 1:
...
...
Patch Set 1:
(7 comments)
Thank you very much for the review Nico!
Actually tgotic proposed a much simpler (and I think better)
approach for checking the MingW environment:
https://github.com/flashrom/flashrom/pull/33
Is it possible to upload a new patchset if I am not an owner at the
gerrit?
Hi Márton,
Did you plan to upload a revision to address Nico's comments? It would be great to get this merged soon and reduce the patch queue.
-- 
To view, visit https://review.coreboot.org/23865
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f856dc4847c4ca9197b1935b7a9b9071b46c70a
Gerrit-Change-Number: 23865
Gerrit-PatchSet: 1
Gerrit-Owner: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Miklós Márton martonmiklosqdev@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Márton Miklós martonmiklosqdev@gmail.com
Gerrit-Comment-Date: Mon, 07 May 2018 02:26:35 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No