Attention is currently required from: Felix Singer, Angel Pons, Nikolai Artemiev.
Hanno Heinrichs has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51048 )
Change subject: flashchips: Add AT25DF011
......................................................................
Patch Set 5:
(4 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/51048/comment/d8d48962_50aa366b
PS4, Line 10:
Please add a link to the datasheet.
Ack
Patchset:
PS5:
Thank you all for your feedback. I think I have taken care of all points.
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/51048/comment/d8a904ac_cdf26e23
PS2, Line 1495: TEST_OK_PREW
Maybe add some details to the commit message about how you tested the chip.
Ack
https://review.coreboot.org/c/flashrom/+/51048/comment/24aab1d4_2524c730
PS2, Line 1521: /* 2.3-3.6V & 2.7-3.6V models available */
The DS-25DF011–032F–5/2017 datasheet states that the range is 1.65v-3.6v.
Ack, Thank you for your feedback and please excuse the delay!
--
To view, visit
https://review.coreboot.org/c/flashrom/+/51048
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5a2141f1380e864c843d6a3008fdb02dc1b75131
Gerrit-Change-Number: 51048
Gerrit-PatchSet: 5
Gerrit-Owner: Hanno Heinrichs
hanno.heinrichs@rwth-aachen.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Edward O'Callaghan
quasisec@chromium.org
Gerrit-CC: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Thu, 07 Oct 2021 08:19:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Nikolai Artemiev
nartemiev@google.com
Gerrit-MessageType: comment