Change in flashrom[master]: flashchips: Add ISSI IS25LQ016

List overview All Threads
Download

newer

older

[XS] Change in flashrom[master]:...

[S] Change in flashrom[master]:...

Angel Pons (Code Review)

16 Apr 2020 16 Apr '20

12:12 p.m.

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/40431 )

Change subject: flashchips: Add ISSI IS25LQ016 ......................................................................

flashchips: Add ISSI IS25LQ016

Datasheet: http://www.issi.com/WW/pdf/25LQ016.pdf Tested all four PREW functions with a FT2232H.

Change-Id: I02f19767b8a60fb2d37adab34894b6edb6ac4494 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M flashchips.c M flashchips.h 2 files changed, 39 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/31/40431/1

diff --git a/flashchips.c b/flashchips.c index b4006df..a25f915 100644 --- a/flashchips.c +++ b/flashchips.c @@ -7049,6 +7049,44 @@

{ .vendor = "ISSI", + .name = "IS25LQ016", + .bustype = BUS_SPI, + .manufacture_id = ISSI_ID_SPI, + .model_id = ISSI_IS25LQ016, + .total_size = 2048, + .page_size = 256, + /* OTP: 1024B total; read 0x4b; write 0xb1 */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI, + .tested = TEST_OK_PREW, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 512} }, + .block_erase = spi_block_erase_20, + }, { + .eraseblocks = { {4 * 1024, 512} }, + .block_erase = spi_block_erase_d7, + }, { + .eraseblocks = { {64 * 1024, 32} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {2 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_60, + }, { + .eraseblocks = { {2 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, + .voltage = {2300, 3600}, + }, + + { + .vendor = "ISSI", .name = "IS25WP032", .bustype = BUS_SPI, .manufacture_id = ISSI_ID_SPI, diff --git a/flashchips.h b/flashchips.h index e5ef390..b5c0aeb 100644 --- a/flashchips.h +++ b/flashchips.h @@ -459,6 +459,7 @@ #define ISSI_IS25LP064 0x6017 #define ISSI_IS25LP128 0x6018 #define ISSI_IS25LP256 0x6019 +#define ISSI_IS25LQ016 0x1445 #define ISSI_IS25WP032 0x7016 #define ISSI_IS25WP064 0x7017 #define ISSI_IS25WP128 0x7018

Attachments:

attachment.htm (text/html — 5.7 KB)

Show replies by date

Simon Buhrow (Code Review)

5 May 5 May

3:38 p.m.

Simon Buhrow has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40431 )

Change subject: flashchips: Add ISSI IS25LQ016 ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/flashrom/+/40431 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I02f19767b8a60fb2d37adab34894b6edb6ac4494 Gerrit-Change-Number: 40431 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 05 May 2020 13:38:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

4:20 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40431 )

Change subject: flashchips: Add ISSI IS25LQ016 ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/flashrom/+/40431 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I02f19767b8a60fb2d37adab34894b6edb6ac4494 Gerrit-Change-Number: 40431 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 05 May 2020 14:20:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Nico Huber (Code Review)

8 Oct 8 Oct

6:54 p.m.

Attention is currently required from: Thomas Heijligen, Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40431 )

Change subject: flashchips: Add ISSI IS25LQ016 ......................................................................

Patch Set 2: Code-Review+1

(3 comments)

Patchset:

PS2: Looks good beside two cosmetic issues.

File flashchips.c:

https://review.coreboot.org/c/flashrom/+/40431/comment/32189cfc_0c120a51 PS2, Line 7444: 1024B Datasheet says 256B?

https://review.coreboot.org/c/flashrom/+/40431/comment/2a40338a_e9ffac00 PS2, Line 7467: }, Missing

.printlock = spi_prettyprint_status_register_bp3_srwd,

-- To view, visit https://review.coreboot.org/c/flashrom/+/40431 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I02f19767b8a60fb2d37adab34894b6edb6ac4494 Gerrit-Change-Number: 40431 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Singer felixsinger@posteo.net Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen src@posteo.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Attention: Thomas Heijligen src@posteo.de Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Fri, 08 Oct 2021 16:54:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Anastasia Klimchuk (Code Review)

2 Jun 2 Jun

3:22 p.m.

New subject: [S] Change in flashrom[master]: flashchips: Add ISSI IS25LQ016

Attention is currently required from: Angel Pons, Simon Buhrow, Thomas Heijligen.

Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40431?usp=email )

Change subject: flashchips: Add ISSI IS25LQ016 ......................................................................

Patch Set 2:

(1 comment)

Patchset:

PS2: Angel, would you try and finish this patch? It needs a manual rebase, because all fn pointers are enums now. Thank you!

-- To view, visit https://review.coreboot.org/c/flashrom/+/40431?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I02f19767b8a60fb2d37adab34894b6edb6ac4494 Gerrit-Change-Number: 40431 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen src@posteo.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Anastasia Klimchuk aklm@chromium.org Gerrit-Attention: Simon Buhrow Gerrit-Attention: Thomas Heijligen src@posteo.de Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-Comment-Date: Fri, 02 Jun 2023 13:22:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Anastasia Klimchuk (Code Review)

5 Aug 5 Aug

3:10 p.m.

New subject: [S] Change in flashrom[master]: flashchips: Add ISSI IS25LQ016

Attention is currently required from: Anastasia Klimchuk, Angel Pons, Nico Huber, Paul Menzel, Simon Buhrow, Thomas Heijligen.

Anastasia Klimchuk has uploaded a new patch set (#3) to the change originally created by Angel Pons. ( https://review.coreboot.org/c/flashrom/+/40431?usp=email )

The following approvals got outdated and were removed: Code-Review+1 by Nico Huber, Code-Review+1 by Paul Menzel, Code-Review+1 by Simon Buhrow, Verified+1 by build bot (Jenkins)

Change subject: flashchips: Add ISSI IS25LQ016 ......................................................................

flashchips: Add ISSI IS25LQ016

Datasheet: http://www.issi.com/WW/pdf/25LQ016.pdf Tested all four PREW functions with a FT2232H.

Change-Id: I02f19767b8a60fb2d37adab34894b6edb6ac4494 Signed-off-by: Angel Pons th3fanbus@gmail.com Signed-off-by: Anastasia Klimchuk aklm@flashrom.org --- M flashchips.c M include/flashchips.h 2 files changed, 41 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/31/40431/3

-- To view, visit https://review.coreboot.org/c/flashrom/+/40431?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I02f19767b8a60fb2d37adab34894b6edb6ac4494 Gerrit-Change-Number: 40431 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen src@posteo.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Attention: Simon Buhrow Gerrit-Attention: Nico Huber nico.h@gmx.de Gerrit-Attention: Paul Menzel paulepanter@mailbox.org Gerrit-Attention: Thomas Heijligen src@posteo.de Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org Gerrit-MessageType: newpatchset

Anastasia Klimchuk (Code Review)

3:17 p.m.

New subject: [S] Change in flashrom[master]: flashchips: Add ISSI IS25LQ016

Attention is currently required from: Angel Pons, Nico Huber, Nikolai Artemiev, Paul Menzel, Simon Buhrow, Thomas Heijligen.

Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40431?usp=email )

Change subject: flashchips: Add ISSI IS25LQ016 ......................................................................

Patch Set 3:

(3 comments)

Patchset:

PS3: I did a manual rebase, checked the values from datasheet. Needs another pair of eyes to review and approve :)

File flashchips.c:

https://review.coreboot.org/c/flashrom/+/40431/comment/fb3b1944_e0d2f54a : PS2, Line 7444: 1024B

...

Datasheet says 256B?

Done

https://review.coreboot.org/c/flashrom/+/40431/comment/c6d17b8e_f2269759 : PS2, Line 7467: },

...

Missing […]

Done

-- To view, visit https://review.coreboot.org/c/flashrom/+/40431?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I02f19767b8a60fb2d37adab34894b6edb6ac4494 Gerrit-Change-Number: 40431 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Nikolai Artemiev nartemiev@google.com Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen src@posteo.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Attention: Simon Buhrow Gerrit-Attention: Nico Huber nico.h@gmx.de Gerrit-Attention: Paul Menzel paulepanter@mailbox.org Gerrit-Attention: Thomas Heijligen src@posteo.de Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-Attention: Nikolai Artemiev nartemiev@google.com Gerrit-Comment-Date: Sat, 05 Aug 2023 13:17:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber nico.h@gmx.de Gerrit-MessageType: comment

Nikolai Artemiev (Code Review)

11 Aug 11 Aug

3:36 a.m.

New subject: [S] Change in flashrom[master]: flashchips: Add ISSI IS25LQ016

Attention is currently required from: Anastasia Klimchuk, Angel Pons, Nico Huber, Paul Menzel, Simon Buhrow, Thomas Heijligen.

Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40431?usp=email )

Change subject: flashchips: Add ISSI IS25LQ016 ......................................................................

Patch Set 3: Code-Review+2

-- To view, visit https://review.coreboot.org/c/flashrom/+/40431?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I02f19767b8a60fb2d37adab34894b6edb6ac4494 Gerrit-Change-Number: 40431 Gerrit-PatchSet: 3 Gerrit-Owner: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Nikolai Artemiev nartemiev@google.com Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org Gerrit-Reviewer: Simon Buhrow Gerrit-Reviewer: Thomas Heijligen src@posteo.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Attention: Simon Buhrow Gerrit-Attention: Nico Huber nico.h@gmx.de Gerrit-Attention: Paul Menzel paulepanter@mailbox.org Gerrit-Attention: Thomas Heijligen src@posteo.de Gerrit-Attention: Angel Pons th3fanbus@gmail.com Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org Gerrit-Comment-Date: Fri, 11 Aug 2023 01:36:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Nikolai Artemiev (Code Review)

15 Aug 15 Aug

8:11 a.m.

New subject: [S] Change in flashrom[master]: flashchips: Add ISSI IS25LQ016

Nikolai Artemiev has submitted this change. ( https://review.coreboot.org/c/flashrom/+/40431?usp=email )

Change subject: flashchips: Add ISSI IS25LQ016 ......................................................................

flashchips: Add ISSI IS25LQ016

Datasheet: http://www.issi.com/WW/pdf/25LQ016.pdf Tested all four PREW functions with a FT2232H.

Change-Id: I02f19767b8a60fb2d37adab34894b6edb6ac4494 Signed-off-by: Angel Pons th3fanbus@gmail.com Signed-off-by: Anastasia Klimchuk aklm@flashrom.org Reviewed-on: https://review.coreboot.org/c/flashrom/+/40431 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nikolai Artemiev nartemiev@google.com --- M flashchips.c M include/flashchips.h 2 files changed, 41 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Nikolai Artemiev: Looks good to me, approved

diff --git a/flashchips.c b/flashchips.c index 4ca37a7..98bce40 100644 --- a/flashchips.c +++ b/flashchips.c @@ -7723,6 +7723,46 @@ .voltage = {2300, 3600}, },

+ + { + .vendor = "ISSI", + .name = "IS25LQ016", + .bustype = BUS_SPI, + .manufacture_id = ISSI_ID_SPI, + .model_id = ISSI_IS25LQ016, + .total_size = 2048, + .page_size = 256, + /* OTP: 256B total; read 0x4b; write 0xb1 */ + .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI, + .tested = TEST_OK_PREW, + .probe = PROBE_SPI_RDID, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {4 * 1024, 512} }, + .block_erase = SPI_BLOCK_ERASE_20, + }, { + .eraseblocks = { {4 * 1024, 512} }, + .block_erase = SPI_BLOCK_ERASE_D7, + }, { + .eraseblocks = { {64 * 1024, 32} }, + .block_erase = SPI_BLOCK_ERASE_D8, + }, { + .eraseblocks = { {2 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_60, + }, { + .eraseblocks = { {2 * 1024 * 1024, 1} }, + .block_erase = SPI_BLOCK_ERASE_C7, + } + }, + .printlock = SPI_PRETTYPRINT_STATUS_REGISTER_BP3_SRWD, + .unlock = SPI_DISABLE_BLOCKPROTECT, + .write = SPI_CHIP_WRITE256, + .read = SPI_CHIP_READ, + .voltage = {2300, 3600}, + }, + { .vendor = "ISSI", .name = "IS25WP016", diff --git a/include/flashchips.h b/include/flashchips.h index 9e2564c..976b4cb 100644 --- a/include/flashchips.h +++ b/include/flashchips.h @@ -478,6 +478,7 @@ #define ISSI_IS25LP064 0x6017 #define ISSI_IS25LP128 0x6018 #define ISSI_IS25LP256 0x6019 +#define ISSI_IS25LQ016 0x1445 #define ISSI_IS25WP016 0x7015 #define ISSI_IS25WP020 0x7012 #define ISSI_IS25WP032 0x7016

494

days inactive

1710

days old

flashrom-gerrit@flashrom.org

8 comments

6 participants

tags (0)

participants (6)

Anastasia Klimchuk (Code Review)
Angel Pons (Code Review)
Nico Huber (Code Review)
Nikolai Artemiev (Code Review)
Paul Menzel (Code Review)
Simon Buhrow (Code Review)