Attention is currently required from: Nico Huber, Keno Fischer.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68468 )
Change subject: flashrom: Make platform-specific errors only print on that platform
......................................................................
Patch Set 2: Code-Review-1
(1 comment)
Patchset:
PS2:
I think it would be better to integrate the message into `platform_get_io_perms` instead of using additional `#ifdef`
--
To view, visit
https://review.coreboot.org/c/flashrom/+/68468
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4d1e369cb60e160f555f1f9f0c832fe27b75e9de
Gerrit-Change-Number: 68468
Gerrit-PatchSet: 2
Gerrit-Owner: Keno Fischer
keno@alumni.harvard.edu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Keno Fischer
keno@alumni.harvard.edu
Gerrit-Comment-Date: Mon, 17 Oct 2022 17:50:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment