Stefan Tauner has posted comments on this change. ( https://review.coreboot.org/21834 )
Change subject: fixup! Convert flashrom to git ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/21834/1/util/git-hooks/pre-push File util/git-hooks/pre-push:
https://review.coreboot.org/#/c/21834/1/util/git-hooks/pre-push@34 PS1, Line 34: (([0-9]+.)+([0-9]+))$
Why the outer-most parentheses? Why not start with ^ ? and didn't
Outer parentheses: because that's needed when using the matching expression of expr: http://pubs.opengroup.org/onlinepubs/9699919799/utilities/expr.html#tag_20_4... ^ is a good idea, no idea why it's not already there. Not sure about the last question... that 'x' is a literal one i presume. Works for me... so this would be '(^([0-9]+.)+([0-9]+).x)$'
https://review.coreboot.org/#/c/21834/1/util/git-hooks/pre-push@51 PS1, Line 51: echo "Neither "Signed-off-by" nor "Acked-by" were found in commit $local_sha in " \
Both Signed-off-by and Acked-by have to be present, don't they? this
Right. Or to be more precise: this is a wrong intermediate wording from an earlier patch set of David. I should have left his last version as is, sorry.
-
Stefan Tauner (Code Review)