Attention is currently required from: Anastasia Klimchuk.
Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79390?usp=email )
Change subject: dummyflasher: Fix JEDEC_WRSR2 and JEDEC_WRSR3 emulation
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Patchset:
PS1:
Look, for example, at `spi_write_register()`:
```c
write_cmd[0] = JEDEC_WRSR;
write_cmd[1] = value;
// ...
write_cmd[0] = JEDEC_WRSR2;
write_cmd[1] = value;
// ...
write_cmd[0] = JEDEC_WRSR3;
write_cmd[1] = value;
```
Current code is correct.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/79390?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Ia0e51a9b8dbd1f67cb947e3ec73f64b6d30cbb97
Gerrit-Change-Number: 79390
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Sun, 03 Dec 2023 13:29:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment