Attention is currently required from: Idwer Vollering, Angel Pons, Light.
Keith Hui has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62761 )
Change subject: board_enable.c: Fix dead assignment
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
Patchset:
PS4:
Okay. I did some build testing with and without the patch. The compiled object code turned out identical. That means the assignment is really not needed, and my compiler (gcc 11.2.1 as supplied by Fedora 34) did not complain.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/62761
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7458b416a69fd5e2aa300ca49d1352b6074ad0bc
Gerrit-Change-Number: 62761
Gerrit-PatchSet: 4
Gerrit-Owner: Light
aarya.chaumal@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Keith Hui
buurin@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk
aklm@chromium.org
Gerrit-CC: Idwer Vollering
vidwer@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Idwer Vollering
vidwer@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Light
aarya.chaumal@gmail.com
Gerrit-Comment-Date: Tue, 15 Mar 2022 03:21:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment