Change in flashrom[master]: ene_lpc.c: Untangle successful vs failed init paths - flashrom-gerrit

29 Apr 2021


      Attention is currently required from: Anastasia Klimchuk.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52685 )
Change subject: ene_lpc.c: Untangle successful vs failed init paths
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File ene_lpc.c:
https://review.coreboot.org/c/flashrom/+/52685/comment/c57f0f63_d8057e63 
PS3, Line 582: 	return 1;
...
No because ene_leave_flash_mode frees ctx_data and there's nothing more to do after it. […]
Oooooh, thanks for correcting me. A bit ugly situation, I trusted
the function name which implies for me that it's symmetrical to
ene_enter_flash_mode().
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/52685
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iac295f1353785cd73d7cb2f19e4a8cbb69beb576
Gerrit-Change-Number: 52685
Gerrit-PatchSet: 3
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Miklós Márton martonmiklosqdev@gmail.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Victor Ding victording@google.com
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Thu, 29 Apr 2021 07:09:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Gerrit-MessageType: comment