Attention is currently required from: Dolan Liu, Nikolai Artemiev, Stefan Reinauer.
Anastasia Klimchuk has posted comments on this change by Dolan Liu. ( https://review.coreboot.org/c/flashrom/+/86348?usp=email )
Change subject: flashchips: Add Macronix MX77U25650FZ4I42 ......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS2:
Hi Anastasia, […]
I am resolving this, thanks to Daniel for review.
Commit Message:
https://review.coreboot.org/c/flashrom/+/86348/comment/d0469c6b_d9bc6a2b?usp... : PS2, Line 12: TEST=sudo emerge flashrom and futility bios image via servo Could you please add one more line just listing the operations you tested (presumably read/write/erase). This line is mentioning internal tools that most of people don't know about.
Keep this line, just add one more line to list the operations tested. thank you!
File flashchips/macronix.c:
https://review.coreboot.org/c/flashrom/+/86348/comment/66343ab4_ae12d8e2?usp... : PS2, Line 2880: There are 3 extra tabs here, can you please remove them? you need the opening bracket to alight with the others