Attention is currently required from: Anastasia Klimchuk, DZ, Nikolai Artemiev, Stefan Reinauer.
Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81350?usp=email )
Change subject: flashchips: Add support for MXIC MX25L12850F
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Why do you need to add this chip as a standalone entry? It's really similar to `MX25L12833F/MX25L12835F/MX25L12845E/MX25L12865E/MX25L12873F`, the only differences are:
1. Extra flag in `feature_bits`
2. Specified `reg_bits`
3. Specified `decode_range`
But quick research through these chips shows me that these changes can be applied to them as well. Does something go wrong when you use the entry I mentioned before?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/81350?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I71ac70d273904f94d015401f9d8df587084efad0
Gerrit-Change-Number: 81350
Gerrit-PatchSet: 1
Gerrit-Owner: DZ
danielzhang@mxic.com.cn
Gerrit-Reviewer: Alexander Goncharov
chat@joursoir.net
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: DZ
danielzhang@mxic.com.cn
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Wed, 20 Mar 2024 15:36:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment