Attention is currently required from: Anastasia Klimchuk.
Evan Benn has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69267 )
Change subject: tests: Detect llvm-cov file io and unmock io functions
......................................................................
Patch Set 3:
(1 comment)
File tests/tests.c:
https://review.coreboot.org/c/flashrom/+/69267/comment/987b98d2_5beaa894
PS3, Line 140: if (!check_suffix(pathname, ".gcda") || !check_suffix(pathname, ".profraw"))
strangely llvm uses fopen in my ubuntu, but uses open in chromeos. Maybe different llvm / libc versions.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/69267
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I21cc1d631e92fa19006b967e85676f108e80b307
Gerrit-Change-Number: 69267
Gerrit-PatchSet: 3
Gerrit-Owner: Evan Benn
evanbenn@google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Mon, 07 Nov 2022 02:30:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment