Attention is currently required from: Felix Singer, Angel Pons.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71578 )
Change subject: internal.c: Factor out laptop alerts into helper func ......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/71578/comment/fd86f654_1052ce47 PS1, Line 9: unfortant
Did you mean `unfortunate`?
Done. Thanks for the review.
File internal.c:
https://review.coreboot.org/c/flashrom/+/71578/comment/7a299383_879178a4 PS1, Line 167:
Add "from parameters", at first it seemed like this is about the function's name. […]
Done
https://review.coreboot.org/c/flashrom/+/71578/comment/60a258db_62565432 PS1, Line 170: /* Report if a non-whitelisted laptop is detected that likely uses a legacy bus. */
Maybe keep this comment on the call site
Done
-
Edward O'Callaghan (Code Review)