Attention is currently required from: Anastasia Klimchuk, Anton Samsonov, Anton Samsonov, Thomas Heijligen.
Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/77778?usp=email )
Change subject: Makefile,meson.build: Add support for Sphinx versions prior to 4.x
......................................................................
Patch Set 6:
(1 comment)
File doc/meson.build:
https://review.coreboot.org/c/flashrom/+/77778/comment/b49b18c0_16402256 :
PS6, Line 3: sphinx_wrapper = meson.current_source_dir() + '/sphinx-wrapper.sh'
`current_source_dir() / 'sphinx-wrapper.sh'` is a little nicer here. (`/` on strings is equivalent to `join_paths(x, y)`).
--
To view, visit
https://review.coreboot.org/c/flashrom/+/77778?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I9cd280551a1ba4d17edb2e857d56f80431b61e1b
Gerrit-Change-Number: 77778
Gerrit-PatchSet: 6
Gerrit-Owner: Anton Samsonov
devel@zxlab.ru
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anton Samsonov
avscomputing@gmail.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Anton Samsonov
avscomputing@gmail.com
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Anton Samsonov
devel@zxlab.ru
Gerrit-Comment-Date: Sun, 04 Feb 2024 22:22:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment