Change in flashrom[master]: flashrom.c: Add 64KiB write granularity - flashrom-gerrit

21 Jun 2021


      Attention is currently required from: Angel Pons.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55713 )
Change subject: flashrom.c: Add 64KiB write granularity
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/55713/comment/a881a8fc_07129b99 
PS1, Line 7: KB
...
Strictly speaking, this should be `KiB`. […]
Done
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/55713/comment/215a8093_cb22952d 
PS1, Line 506: 1024 * 64
...
nit: I'd use `64 * 1024` to be in line with `64 kilobytes`.
Done
https://review.coreboot.org/c/flashrom/+/55713/comment/1e2b8fdc_fc61c319 
PS1, Line 578: 1024 * 64
...
Same here
Done
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/55713
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I69801f581d0cb9b85f6596de7e1267ef9317673f
Gerrit-Change-Number: 55713
Gerrit-PatchSet: 2
Gerrit-Owner: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 21 Jun 2021 10:38:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment