Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Edward O'Callaghan, Peter Marheine, Stefan Reinauer, Swift Geek (Sebastian Grzywna), Thomas Heijligen.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75906?usp=email )
Change subject: doc: Add new Development guidelines ......................................................................
Patch Set 2:
(3 comments)
File doc/dev_guide/development_guidelines.rst:
https://review.coreboot.org/c/flashrom/+/75906/comment/d498da49_ebf81d2e : PS1, Line 5: Intro, is there anything useful to say? No idea what to put in an introduction, maybe:
This document describes the rules and recommendations about the development, contribution and review processes.
Note: it may be useful to visibly mark open questions in a patch with a `TODO` prefix or similar, so as to (hopefully) catch the reviewers' attention.
File doc/dev_guide/development_guidelines.rst:
https://review.coreboot.org/c/flashrom/+/75906/comment/5c59fb8a_2e32523a : PS2, Line 7: Set up the git repository and dev environment +1, having detailed instructions in a separate "how-to" document (or multiple) would make more sense. To us, a guideline would be something containing general rules, principles and/or pieces of advice about something (in this case, the development/contribution/review processes).
One could link to the how-to's with something like this:
For instructions on how to clone the flashrom repository for development, please refer to the <link to "how-to clone" page>.
https://review.coreboot.org/c/flashrom/+/75906/comment/4055a303_6dae5165 : PS2, Line 279: Except, if a commit The comma seems rather clunky, how about:
Exception: if a commit is ...
-
Angel Pons (Code Review)