Urja Rannikko has uploaded a new change for review. ( https://review.coreboot.org/19614 )
Change subject: cli_common: Dont request reports from known-bad chip operations ......................................................................
cli_common: Dont request reports from known-bad chip operations
Change-Id: Ic4dc0d85534f2fcfe4dcb9733d4994c8853b48a7 Signed-off-by: Urja Rannikko urjaman@gmail.com --- M cli_common.c 1 file changed, 15 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/14/19614/1
diff --git a/cli_common.c b/cli_common.c index 71cc2dd..6bdc086 100644 --- a/cli_common.c +++ b/cli_common.c @@ -70,10 +70,12 @@ msg_cdbg("This chip's main memory can not be erased/written by design.\n"); }
+ if ((chip->tested.probe == BAD) || (chip->tested.probe == NT) || (chip->tested.read == BAD) || (chip->tested.read == NT) || (chip->tested.erase == BAD) || (chip->tested.erase == NT) || (chip->tested.write == BAD) || (chip->tested.write == NT)){ + int untested = 0; msg_cinfo("===\n"); if ((chip->tested.probe == BAD) || (chip->tested.read == BAD) || @@ -104,14 +106,20 @@ if (chip->tested.write == NT) msg_cinfo(" WRITE"); msg_cinfo("\n"); + untested = 1; } - msg_cinfo("The test status of this chip may have been updated in the latest development\n" - "version of flashrom. If you are running the latest development version,\n" - "please email a report to flashrom@flashrom.org if any of the above operations\n" - "work correctly for you with this flash chip. Please include the flashrom log\n" - "file for all operations you tested (see the man page for details), and mention\n" - "which mainboard or programmer you tested in the subject line.\n" - "Thanks for your help!\n"); + if (untested) { + msg_cinfo("The test status of this chip may have been updated in the latest development\n" + "version of flashrom. If you are running the latest development version,\n" + "please email a report to flashrom@flashrom.org if any of the above operations\n" + "work correctly for you with this flash chip. Please include the flashrom log\n" + "file for all operations you tested (see the man page for details), and mention\n" + "which mainboard or programmer you tested in the subject line.\n" + "Thanks for your help!\n"); + } else { + msg_cinfo("The test status of this chip may have been updated in the latest development\n" + "version of flashrom.\n"); + } } }