Attention is currently required from: Nico Huber, Angel Pons. Thomas Walker has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52310 )
Change subject: flashchips: Add Spansion/Cypress S25FL256L ......................................................................
Patch Set 6:
(2 comments)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/52310/comment/51a2d3cf_453deb75 PS5, Line 16387: FEATURE_4BA
I see no mention of EAR (extended address register) in the datasheet, so that should be […]
Forgive me if I'm incorrect, but in the datasheet there is a section: 6.1.1 Extended Address
""" Legacy commands continue to support 24-bit addresses for backward software compatibility. Extended 32-bit addresses are enabled in two ways: - Extended address mode - 4 Byte address commands """
File spi25.c:
https://review.coreboot.org/c/flashrom/+/52310/comment/59c8eea4_fc5eee36 PS5, Line 492: true
We could put it next to _5c
Moved to a more suitable spot.
-
Thomas Walker (Code Review)