Attention is currently required from: Edward O'Callaghan, Angel Pons, Arthur Heymans, Alexander Goncharov.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73040 )
Change subject: printf: Use inttype.h macros for format strings
......................................................................
Patch Set 8:
(1 comment)
Patchset:
PS8:
I am wondering is this should be in guidelines somewhere. […]
yes, we should put this in the developer guidelines. I'll also search for the possibility of automatic testing this. This would make keeping track of it much easier.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/73040
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia75b6df981ce60c891161fe553c7ceab8570178d
Gerrit-Change-Number: 73040
Gerrit-PatchSet: 8
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Alexander Goncharov
chat@joursoir.net
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Alexander Goncharov
chat@joursoir.net
Gerrit-Comment-Date: Sat, 18 Mar 2023 10:17:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment