Change in flashrom[master]: test_build.sh: use sh from env - flashrom-gerrit

14 Apr 2021


      Attention is currently required from: Nico Huber, Paul Menzel.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51978 )
Change subject: test_build.sh: use sh from env
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
...
Which ones? I'm curious. […]
with an absolute path as interpreter you are sure that your script will run by that binary, or the linked one. With /usr/bin/env the first suitable binary with this name in your path is chosen to run the script.
On "/bin/sh" it's not this necessary, since most distributions provide /bin/sh for compatibility. Other interpreter may be only available though PATH and not as /bin/xyz
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/51978
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3897b8d980425ecbb89b238d4a766f628cf9d3e6
Gerrit-Change-Number: 51978
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Comment-Date: Wed, 14 Apr 2021 11:37:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel paulepanter@mailbox.org
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment