Attention is currently required from: Thomas Heijligen, Evan Benn.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69268 )
Change subject: tests: Add llvm-cov option and run target for code coverage ......................................................................
Patch Set 5:
(3 comments)
Patchset:
PS5: Thanks so much Evan for setting up coverage measurement!
File meson.build:
https://review.coreboot.org/c/flashrom/+/69268/comment/f47870ed_6a60aa6c PS5, Line 534: if get_option('llvm_cov') Also need to check that tests feature is enabled
File meson_options.txt:
https://review.coreboot.org/c/flashrom/+/69268/comment/000eb271_45383df3 PS5, Line 19: type : 'boolean' I think this should be a feature, like unit tests themselves. Also llvm_cov feature should depend on tests feature (you can't measure coverage is tests are disabled).