Attention is currently required from: Paul Menzel, Angel Pons, Light. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62725 )
Change subject: libflashrom.c: Fix unintialized value passed to function ......................................................................
Patch Set 15:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62725/comment/4cbde013_a3299139 PS15, Line 11: later. Your intention is missing. Suggestion: Thus, initialize it with NULL.
https://review.coreboot.org/c/flashrom/+/62725/comment/fdc45819_8f815ec6 PS15, Line 11: value Replace "value" with "variable"
https://review.coreboot.org/c/flashrom/+/62725/comment/b303fc63_4e472c33 PS15, Line 12: You are also setting dump_layout to NULL. Please mention that too. Suggestion: For completeness, also initialize dump_layout with NULL.
-
Felix Singer (Code Review)