Attention is currently required from: Paul Menzel, Angel Pons, Light.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62725 )
Change subject: libflashrom.c: Fix unintialized value passed to function
......................................................................
Patch Set 15:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62725/comment/4cbde013_a3299139
PS15, Line 11: later.
Your intention is missing. Suggestion:
Thus, initialize it with NULL.
https://review.coreboot.org/c/flashrom/+/62725/comment/fdc45819_8f815ec6
PS15, Line 11: value
Replace "value" with "variable"
https://review.coreboot.org/c/flashrom/+/62725/comment/b303fc63_4e472c33
PS15, Line 12:
You are also setting dump_layout to NULL. Please mention that too. Suggestion:
For completeness, also initialize dump_layout with NULL.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/62725
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iacbd7bf9cdf897cc2a732c1dc6568845a4ab804d
Gerrit-Change-Number: 62725
Gerrit-PatchSet: 15
Gerrit-Owner: Light
aarya.chaumal@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Light
aarya.chaumal@gmail.com
Gerrit-Comment-Date: Thu, 24 Mar 2022 08:52:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment